Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: migrate "chmod" to matcher API, warn unmatched "diff" paths #3476

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Apr 9, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@torquestomp torquestomp self-assigned this Apr 9, 2024
cli/tests/test_diff_command.rs Outdated Show resolved Hide resolved
cli/src/commands/chmod.rs Outdated Show resolved Hide resolved
lib/src/fileset.rs Outdated Show resolved Hide resolved
@yuja yuja force-pushed the push-onoqxskmtkor branch from 9977a9b to 32bcd77 Compare April 9, 2024 15:16
yuja added 3 commits April 10, 2024 15:08
The primary use case is to warn unmatched paths. I originally thought paths in
negated expressions shouldn't be checked, but doing that seems rather
inconsistent than useful. For example, "~x" in "jj split '~x'" should match at
least one file to split to non-empty revisions.
Maybe we can optimize it to check paths during diffing, but I think it's okay
to add extra lookup cost at the end. The size of the path arguments is usually
small.

Closes jj-vcs#505
@yuja yuja force-pushed the push-onoqxskmtkor branch from 32bcd77 to 445044e Compare April 10, 2024 06:17
@yuja yuja merged commit 1bfacea into jj-vcs:main Apr 10, 2024
16 checks passed
@yuja yuja deleted the push-onoqxskmtkor branch April 10, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants